From dee8ffe1f7e9243ca8f6e938af3929436400b333 Mon Sep 17 00:00:00 2001
From: dede <luca@g-laber.de>
Date: Tue, 19 Dec 2023 12:06:34 +0100
Subject: [PATCH] modify task names and replace facts by vars

---
 roles/config_locale/tasks/main.yml | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/roles/config_locale/tasks/main.yml b/roles/config_locale/tasks/main.yml
index b1d2c2e..a3fe83a 100644
--- a/roles/config_locale/tasks/main.yml
+++ b/roles/config_locale/tasks/main.yml
@@ -2,13 +2,13 @@
 # got this from here:
 # https://serverfault.com/questions/959026/how-do-i-generate-and-set-the-locale-using-ansible/981742#981742
 
-- name: ensure locale files for '{{ system_locale }}' are available
+- name: ensure locale files are available for {{ system_locale }}
   become: true
   community.general.locale_gen:
     name: "{{ system_locale }}"
     state: present
 
-- name: ensure locale files for '{{ system_language }}' are available
+- name: ensure locale files are available for {{ system_language }}
   become: true
   community.general.locale_gen:
     name: "{{ system_language }}"
@@ -19,17 +19,23 @@
   register: locale_status
   changed_when: false
 
-- name: set facts locale_lang and locale_language
-  ansible.builtin.set_fact:
-    locale_lang: "{{ locale_status.stdout | regex_search('LANG=([^\n]+)', '\\1') | first }}"
-    locale_language: "{{ locale_status.stdout | regex_search('LANGUAGE=([^\n]+)', '\\1') | default([locale_lang], true) | first }}"
+# - name: set facts locale_lang and locale_language
+#   ansible.builtin.set_fact:
+#     locale_lang: "{{ locale_status.stdout | regex_search('LANG=([^\n]+)', '\\1') | first }}"
+#     locale_language: "{{ locale_status.stdout | regex_search('LANGUAGE=([^\n]+)', '\\1') | default([locale_lang], true) | first }}"
 
 - name: set locale to '{{ system_locale }}'
   become: true
-  ansible.builtin.command: localectl set-locale LANG={{ system_locale }}
   changed_when: locale_lang != system_locale
+  ansible.builtin.command:
+    cmd: localectl set-locale LANG={{ system_locale }}
+  vars:
+    locale_lang: "{{ locale_status.stdout | regex_search('LANG=([^\n]+)', '\\1') | first }}"
 
 - name: set language to '{{ system_language }}'
   become: true
-  ansible.builtin.command: localectl set-locale LANGUAGE={{ system_language }}
   changed_when: locale_language != system_language
+  ansible.builtin.command:
+    cmd: localectl set-locale LANGUAGE={{ system_language }}
+  vars:
+    locale_language: "{{ locale_status.stdout | regex_search('LANGUAGE=([^\n]+)', '\\1') | default([locale_lang], true) | first }}"